Re: [RFC PATCH] Only process ABS_MT_SLOT where there are slots available

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Antonio,

On Thu, Aug 18, 2011 at 12:28:53PM +0200, Antonio Ospite wrote:
> This fixes the case when a non-multitouch device happens to have a HID
> code equal to ABS_MT_SLOT, like the Sony Sixaxis has for the left dpad
> analog control.
> 
> Signed-off-by: Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx>
> Cc: Simon Wood <simon@xxxxxxxxxxxxx>
> Cc: Henrik Rydberg <rydberg@xxxxxxxxxxx>
> Cc: virtuousfox@xxxxxxxxx
> ---
> 
> Hi,
> 
> following up from the discussion at 
> http://thread.gmane.org/gmane.linux.kernel.input/19632 I've come up with this 
> workaround to make the dpad left analog axis of the Sony Sixaxis controller 
> working. What happens is that this button has a code of 0x2f (ABS_MT_SLOT) 
> which gets some special handling regardless of the device being a multitouch one 
> or not.
> 
> I do not know anything about multitouch devices, so I am not sure if this 
> hack may break something else, I'd like some advice here.
> 
> Another possibility could be to remap the code at the HID level for the 
> Sixaxis only, Simon you suggested this, are you willing to do that if this 
> will be the preferred way? My HID-fu is way worse than yours and It'll take a 
> lot more time for me.

No, drivers should not be emitting ABS_MT_SLOT if they are not
multitouch devices and not using MT-B protocol. You'll have to remap the
axis into something more suitable.

Thanks,
Dmitry

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux