On Mon, Aug 22, 2011 at 12:31 AM, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > Hi Javier, > Hi Dmitry, Thank you very much for the review. > > Still reading through the patches, but have one question: > > > Why do we need to get gpio/irq from platform data instead of having > board code set up controllers appropriately and use IRQ either from I2C > client structure or from SPI? > > Thanks. > > -- > Dmitry > The original author of this driver is Kevin McNeely (cc'ed in this patch submission). I've only added multi-touch protocol type B support (which was a requirement for upstream acceptance) and resubmit the patch-set. I think he will better answer your questions about the driver design. Kevin? Best regards, -- Javier Martínez Canillas (+34) 682 39 81 69 Barcelona, Spain -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html