On Fri, Aug 12, 2011 at 10:58:27AM +0200, Michael Hennerich wrote: > On 08/04/2011 09:54 AM, Dmitry Torokhov wrote: > >On Wed, Aug 03, 2011 at 09:40:22AM +0100, Hennerich, Michael wrote: > >>Hennerich, Michael wrote on 2011-07-13: > >>>Dmitry Torokhov wrote on 2011-05-19: > >>>>On Wed, May 18, 2011 at 08:10:09PM +0100, Hennerich, Michael wrote: > >>>>>Dmitry Torokhov wrote on 2011-05-18: > >>>>>>On Tue, May 17, 2011 at 12:01:27PM +0100, Hennerich, Michael wrote: > >>>>>>>Hi Dmitry, > >>>>>>> > >>>>>>>I noticed you added patches 2/6, 3/6, 4/6 and 5/6 to your next tree. > >>>>>>>But how about these ones? > >>>>>>> > >>>>>>>[PATCH v2 1/6] input: misc: AD714x: The interrupt status > >>>>>>>registers should be read in row. [PATCH v2 6/6] input: misc: > >>>>>>>AD714x: Fix endianness issues. > >>>>>>> > >>>>>>Hi Michael, > >>>>>> > >>>>>>Still pondering these two, give me a couple of days please... > >>>>>> > >>>>>>Thanks. > >>>>>> > >>>>>Hi Dmitry, > >>>>> > >>>>>No Problem - let me know in case you need some further clarification. > >>>>>Both patches are tested on several platforms and addresses real issues. > >>>>> > >>>>>BTW - are you going to merge the adp5589 driver anytime soon? > >>>>>Are there open issues you like to get addressed first? > >>>>> > >>>>Oh, thanks for reminding me of it, I queued it for .40. > >>>> > >>>>Thanks. > >>>> > >>>Hi Dmitry, > >>> > >>>Still pondering these two? > >>> > >>>[PATCH v2 1/6] input: misc: AD714x: > >>> The interrupt status registers should be read in row. > >>>[PATCH v2 6/6] input: misc: AD714x: Fix endianness issues. > >>> > >>>Greetings, > >>>Michael > >>> > >>Hi Dmitry, > >> > >>Are you going to apply these two missing patches? > >> > >Hi Michael, > > > >Yes, should be in the next pull (not todays one). > > > >Thanks. > > > Hi Dmitry, > > Hmmm... Are you sure? > I can't find it. Hi Michael, No, I haven't applied it yet, sorry. I was looking through the code and realized that spi_write requires use of DMA-safe buffers. Also, if we are concerned with performance we should not use spi_write_then_read, but rather use the same buffer we'll be using for spi_write and avoid locking and extra copying. I'll be sending updated version out shortly and if I did not mess up and it still works fro you then I swear I'll apply it ;) Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
