On 08/18/2011 11:47 AM, Li Zefan wrote:
+
+ case 3:
+ if (elantech_ps2_command(psmouse, NULL, ETP_PS2_CUSTOM_COMMAND) ||
+ elantech_ps2_command(psmouse, NULL, ETP_REGISTER_READWRITE) ||
+ elantech_ps2_command(psmouse, NULL, ETP_PS2_CUSTOM_COMMAND) ||
+ elantech_ps2_command(psmouse, NULL, reg) ||
+ elantech_ps2_command(psmouse, param, PSMOUSE_CMD_GETINFO)) {
+ rc = -1;
+ }
Prefer to remove these big brace ?
also with "case 1, case 2 "?
Just wondering What's wrong with this piece of code and what do you
sugguest to improve it?
I think no need to add a '{}' with the *if* ?
and remove the '{}' in whole elantech_read_reg() and
elantech_write_reg(), right?
-Wanlong Gao
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
