Hi Henrik, 2011/8/12 Henrik Rydberg <rydberg@xxxxxxxxxxx>: > Hi Zhang, > >> This is the patch after change to mt Protocol-B. >> but I have a issue with test tool, in the orignal patch, I use >> android to do the test, but android still not support Protocol B. > > The device seems to send finger changes sequentually, resulting in one > packet (terminated with input sync) for each finger change. Is this > the intention/necessary? Some egalax firmware (hid version) seems to > work this way. When I make v2 patch, I've a look the Protocol B's driver in upstream, but there were two type of multi-point report fashion, One type is report all the finger status in one input sync(), and separate each mt point with mt_input_slot(), like wocom driver. But there was some driver (like egalax hid version), send each mt point with one input_sync(), but I'm worry about if main stream user space frameworks(xorg mtouch etc,) support this behavior well. What's your point of view about this ? > > The usage of REPORT_MODE_* is unclear to me too. In the programming manual this mode 's name is "single touch mouse mode", may be it will be a better name for this mode ? > > Other than that, the patch looks nice (at first glance). > > Thanks, > Henrik > Thanks, Jiejing -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html