Re: [PATCH] Input: mma8450: add device tree probe support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 29, 2011 at 10:38 AM, Shawn Guo <shawn.guo@xxxxxxxxxxxxx> wrote:
> Any comments?
>

Shawn,

Patch looks OK to me.

> Regards,
> Shawn
>
> On Fri, Jul 22, 2011 at 12:25:51AM +0800, Shawn Guo wrote:
>> It adds device tree probe support for mma8450 driver.
>>
>> Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
>> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
>> Cc: Sammy He <r62914@xxxxxxxxxxxxx>
>> Cc: Eric Miao <eric.miao@xxxxxxxxxx>
>> Cc: Dmitry Torokhov <dtor@xxxxxxx>
>> ---
>>  .../devicetree/bindings/input/fsl-mma8450.txt      |   11 +++++++++++
>>  drivers/input/misc/mma8450.c                       |    8 ++++++++
>>  2 files changed, 19 insertions(+), 0 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/input/fsl-mma8450.txt
>>
>> diff --git a/Documentation/devicetree/bindings/input/fsl-mma8450.txt b/Documentation/devicetree/bindings/input/fsl-mma8450.txt
>> new file mode 100644
>> index 0000000..a00c94c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/fsl-mma8450.txt
>> @@ -0,0 +1,11 @@
>> +* Freescale MMA8450 3-Axis Accelerometer
>> +
>> +Required properties:
>> +- compatible : "fsl,mma8450".
>> +
>> +Example:
>> +
>> +accelerometer: mma8450@1c {
>> +     compatible = "fsl,mma8450";
>> +     reg = <0x1c>;
>> +};
>> diff --git a/drivers/input/misc/mma8450.c b/drivers/input/misc/mma8450.c
>> index 20f8f92..6c76cf7 100644
>> --- a/drivers/input/misc/mma8450.c
>> +++ b/drivers/input/misc/mma8450.c
>> @@ -24,6 +24,7 @@
>>  #include <linux/delay.h>
>>  #include <linux/i2c.h>
>>  #include <linux/input-polldev.h>
>> +#include <linux/of_device.h>
>>
>>  #define MMA8450_DRV_NAME     "mma8450"
>>
>> @@ -229,10 +230,17 @@ static const struct i2c_device_id mma8450_id[] = {
>>  };
>>  MODULE_DEVICE_TABLE(i2c, mma8450_id);
>>
>> +static const struct of_device_id mma8450_dt_ids[] = {
>> +     { .compatible = "fsl,mma8450", },
>> +     { /* sentinel */ }
>> +};
>> +MODULE_DEVICE_TABLE(i2c, mma8450_dt_ids);
>> +
>>  static struct i2c_driver mma8450_driver = {
>>       .driver = {
>>               .name   = MMA8450_DRV_NAME,
>>               .owner  = THIS_MODULE,
>> +             .of_match_table = mma8450_dt_ids,
>>       },
>>       .probe          = mma8450_probe,
>>       .remove         = __devexit_p(mma8450_remove),
>> --
>> 1.7.4.1
>>
>> _______________________________________________
>> devicetree-discuss mailing list
>> devicetree-discuss@xxxxxxxxxxxxxxxx
>> https://lists.ozlabs.org/listinfo/devicetree-discuss
>>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux