On Thu, 28 Jul 2011, Daniel Drake wrote: > On 28 July 2011 15:53, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > > Shouldn't this also check device_may_wakeup(dev)? �The user might > > disable wakeup for the input device while leaving it enabled for the > > i8042 device. > > As far as I'm aware, there aren't any instances where input devices > are marked as wakeup-capable. So, we're speaking theoretically. Aren't there? I have no idea. But if input devices are never wakeup-capable, why do you name your function "input_may_wakeup()"? > But, what would this mean? On OLPC for example, we can only control > i8042 wakeups. This means we don't get to choose that we want keyboard > wakeups and not mouse. If you enable i8042 wakeups you get both, and > we can't change that, as the wakeup mechanism revolves around the > i8042 controller. I'm using a normal PC with PS/2 mouse and keyboard. It is set up with the keyboard as a wakeup source but not the mouse. Of course, this uses ACPI, which I assume isn't present on OLPC. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
