On Thu, Jul 14, 2011 at 10:21:57AM +0800, jcbian wrote:
> Hi Dmitry & Henrik,
>
> Thanks for your suggestions and modification .I have test it and it works well.
> Indeed,I think the old_touch is not needed,the follow
>
> + if (old_touch)
> + input_mt_sync(tsdata->input);
>
> could be removed. So,How about below?
Also fine, although the removed brackets is a slight style
violation. No need to resend though.
> +static void pixcir_ts_poscheck(struct pixcir_i2c_ts_data *data)
> +{
> + struct pixcir_i2c_ts_data *tsdata = data;
> + u8 rdbuf[10], wrbuf[1] = { 0 };
> + u8 touch, old_touch;
> + int ret;
> +
> + ret = i2c_master_send(tsdata->client, wrbuf, sizeof(wrbuf));
> + if (ret != sizeof(wrbuf)) {
> + dev_err(&tsdata->client->dev,
> + "%s: i2c_master_send failed(), ret=%d\n",
> + __func__, ret);
> + return;
> + }
> +
> + ret = i2c_master_recv(tsdata->client, rdbuf, sizeof(rdbuf));
> + if (ret != sizeof(rdbuf)) {
> + dev_err(&tsdata->client->dev,
> + "%s: i2c_master_recv failed(), ret=%d\n",
> + __func__, ret);
> + return;
> + }
> +
> + touch = rdbuf[0];
> + old_touch = rdbuf[1];
> + if (touch) {
> + u16 posx1 = (rdbuf[3] << 8) | rdbuf[2];
> + u16 posy1 = (rdbuf[5] << 8) | rdbuf[4];
> + u16 posx2 = (rdbuf[7] << 8) | rdbuf[6];
> + u16 posy2 = (rdbuf[9] << 8) | rdbuf[8];
> +
> + input_report_key(tsdata->input, BTN_TOUCH, 1);
> + input_report_abs(tsdata->input, ABS_X, posx1);
> + input_report_abs(tsdata->input, ABS_Y, posy1);
> +
> + input_report_abs(tsdata->input, ABS_MT_POSITION_X, posx1);
> + input_report_abs(tsdata->input, ABS_MT_POSITION_Y, posy1);
> + input_mt_sync(tsdata->input);
> +
> + if (touch == 2) {
> + input_report_abs(tsdata->input,
> + ABS_MT_POSITION_X, posx2);
> + input_report_abs(tsdata->input,
> + ABS_MT_POSITION_Y, posy2);
> + input_mt_sync(tsdata->input);
> + }
> + } else
> + input_report_key(tsdata->input, BTN_TOUCH, 0);
> +
> + input_sync(tsdata->input);
> +}
Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
