Sorry, I fear I am too late, but...
On Thu, Jul 7, 2011 at 2:57 PM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
>
> Newer Synaptics firmware allows to query minimum coordinates reported by
> the device, let's use this data.
>
> Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
> ---
>
> drivers/input/mouse/synaptics.c | 56 ++++++++++++++++++++++++++-------------
> drivers/input/mouse/synaptics.h | 8 ++++--
> 2 files changed, 43 insertions(+), 21 deletions(-)
[...snip...]
> diff --git a/drivers/input/mouse/synaptics.h b/drivers/input/mouse/synaptics.h
> index b8025b0..a4394e1 100644
> --- a/drivers/input/mouse/synaptics.h
> +++ b/drivers/input/mouse/synaptics.h
> @@ -19,7 +19,8 @@
> #define SYN_QUE_RESOLUTION 0x08
> #define SYN_QUE_EXT_CAPAB 0x09
> #define SYN_QUE_EXT_CAPAB_0C 0x0c
> -#define SYN_QUE_EXT_DIMENSIONS 0x0d
> +#define SYN_QUE_EXT_MAX_COORDS 0x0d
> +#define SYN_QUE_EXT_MIN_COORDS 0x0f
>
> /* synatics modes */
> #define SYN_BIT_ABSOLUTE_MODE (1 << 7)
> @@ -73,10 +74,12 @@
> * 2 0x04 reduced filtering firmware does less filtering on
> * position data, driver should watch
> * for noise.
> + * 2 0x20 report min query 0x0f gives min coord reported
> */
> #define SYN_CAP_CLICKPAD(ex0c) ((ex0c) & 0x100000) /* 1-button ClickPad */
> #define SYN_CAP_CLICKPAD2BTN(ex0c) ((ex0c) & 0x000100) /* 2-button ClickPad */
> #define SYN_CAP_MAX_DIMENSIONS(ex0c) ((ex0c) & 0x020000)
> +#define SYN_CAP_MIN_DIMENSIONS(ex0c) ((ex0c) & 0x000200)
I believe "Byte 2, 0x20" is actually 0x002000, not 0x000200.
It would appear that the documentation is inconsistent with
implementation; and, the implementation conflicts with the heretofore
unused "deluxe LED controls" bit.
Thanks,
-Daniel
> #define SYN_CAP_ADV_GESTURE(ex0c) ((ex0c) & 0x080000)
> #define SYN_CAP_REDUCED_FILTERING(ex0c) ((ex0c) & 0x000400)
>
> @@ -134,7 +137,8 @@ struct synaptics_data {
> unsigned long int ext_cap_0c; /* Ext Caps from 0x0c query */
> unsigned long int identity; /* Identification */
> unsigned int x_res, y_res; /* X/Y resolution in units/mm */
> - unsigned int x_max, y_max; /* Max dimensions (from FW) */
> + unsigned int x_max, y_max; /* Max coordinates (from FW) */
> + unsigned int x_min, y_min; /* Min coordinates (from FW) */
>
> unsigned char pkt_type; /* packet type - old, new, etc */
> unsigned char mode; /* current mode byte */
> --
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
