On Mon, Jul 11, 2011 at 01:20:04PM +0100, Mark Brown wrote: > On Mon, Jul 11, 2011 at 12:50:19PM +0200, Yegor Yefremov wrote: > > both touchscreen and regulator units are only working if > > mfd device is activated. So if mfd support is enabled, > > select TPS6507X mfd support automatically. > > > > Signed-off-by: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx> > > This should be split into separate patches and sent to *all* the > relevant maintainers. > > > config TOUCHSCREEN_TPS6507X > > tristate "TPS6507x based touchscreens" > > - depends on I2C > > + depends on I2C && MFD_SUPPORT > > + select TPS6507X > > This isn't a good fix, the driver should depend on the MFD core not > select it. The problem with such dependencies is that user has to first enable MFD core and then hunt through all other menus in search of the function drivers for that chip... Depending on what other things TPS6507X depends on it might be good idea to go ahead and select it. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
