Hello, On Sun, Jul 10, 2011 at 01:06:36AM +0200, Philippe Rétornaz wrote: > The leds and buttons subdevices cannot be used without additional > platform data. > > Use the presence of the platform data to enable the device instead > of an additional flag. I guess you could make some people happy by splitting this patch into: - mfd/mc13xxx: implicitly enable leds and buttons (and regulators?) - drop MC13XXX_USE_... in arch code because the patches have different paths into mainline (unless it's handled otherwise). And I wonder why you introduce MC13XXX_USE_BUTTON in the first place. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html