On Tue, Jul 5, 2011 at 6:26 PM, Ping Cheng <pinglinux@xxxxxxxxx> wrote: > The old code may call input_sync without sending any other events. > Although the sync event will be ignored in the userland, eliminating > unnecessary kernel events is the right way to go. Aligns the code block with previous case statement as well. Reviewed-by: Chris Bagwell <chris@xxxxxxxxxxxxxx> > > Signed-off-by: Ping Cheng <pingc@xxxxxxxxx> > --- > drivers/input/tablet/wacom_wac.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c > index 19554a4..03ebcc8 100644 > --- a/drivers/input/tablet/wacom_wac.c > +++ b/drivers/input/tablet/wacom_wac.c > @@ -300,8 +300,8 @@ static int wacom_graphire_irq(struct wacom_wac *wacom) > wacom->id[1] = 0; > input_report_abs(input, ABS_MISC, wacom->id[1]); > input_event(input, EV_MSC, MSC_SERIAL, 0xf0); > + retval = 1; > } > - retval = 1; > break; > } > exit: > -- > 1.7.5.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html