> > Any particular reason to move these and leave them unassigned for clickpads? > > Yes. The current implementation incorrectly parses the x, y, z of AGM > packets and assigns junk values to the corresponding fields of the > temporary hw struct. Luckily, this struct is then just discarded upon > return (synaptics_parse_hw_state returns 1 causing > synaptics_process_packet() to exit immediately). > > Instead, this patch parses the w value first to determine the packet > type, and then use this packet type information to parse the remaining > position and pressure fields correctly... > > Notice that the "else" clause is taken for SGM packets (w != 2), even > for clickpads. Functionally, there is no difference between assigning new junk or reusing old junk, hence that part of the patch is not strictly needed. Thanks, Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
