> > > In some cases, however, y = 0 is sent by the touchpad. > > > In these cases, the kernel driver should not invert, and just report 0. > > > > > > This patch also refactors the inversion into a macro, and moves it > > > into packet processing instead of during position reporting. > > > > The patch seems to invert the current output? > > By 'current' do you mean referenced from the previous implementation? > Or referenced from the raw input. > It does indeed invert the raw input. > This is the same as the previous implementation did. > The difference is that it does not also invert the special 'y=0' into > an arbitrarily large value. > Is this your concern? It would be clearer to just change the argument of the input_report_abs() instances, would it not? An explanation why zero, outside the value range, should be output also needs a rationale. It would seem such packets should be masked somehow. Thanks, Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
