Hi Chris, On Sun, Jun 12, 2011 at 05:49:49PM -0700, Chris Moeller wrote: > + } else if (xpad->xtype == XTYPE_XBOX360W) { > + if (command >= 0 && command < 16) { > + if (command == 16) > + command = 2 + (xpad->interface_number & 6) / 2; Not commenting on the rest of the patch, but this chunk does not make sense - you go into this branch only if command is less than 16 so it can never be equal to 16 in the nested 'if'. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html