On Thu, 23 Jun 2011 11:01:22 -0700 Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > On Thu, Jun 23, 2011 at 07:25:37AM -0600, Grant Likely wrote: > > On Thu, Jun 23, 2011 at 6:39 AM, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote: > > >> > + - gpios: OF devcie-tree gpio specificatin. > > >> > + - label: Descriptive name of the key. > > >> > + - linux,code: Keycode to emit. > > >> > > >> The fact that this is the Linux internal keycode definitions still > > >> makes me nervous. Is there no existing standard for keycodes emitted > > >> by keyboard devices? > > > > > > There is but no standard lookup table. For Intel MID we do a translation > > > between Linux key names in the firmware and keycodes but there isn't a > > > generic helper for it. > > > > I suppose the Linux keycodes are exported out to userspace, and are > > therefore an ABI which will not change. Okay. > > Right, keycodes form ABI that will not change. > > Another option would be to use codes from HID usage tables but then > they would have to be translated to Linux ones. Dmitry, will you accept this patch also? Until now, part 2/2 is in your tree, thanks for that, but I'd like to know if this part (1/2) will also be accepted? Best regards, -- David Jander Protonic Holland. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
