Hi, On Sun, Jun 19, 2011 at 11:01:43PM +0100, Leigh Brown wrote: > On Sun, 19 Jun 2011 22:56:06 +0300, Felipe Balbi wrote: > >Hi, > > > >On Sun, Jun 19, 2011 at 07:00:13PM +0000, Leigh Brown wrote: > >>Many thanks for trying to assist me with my problem. To recap, > > > >yeah, no problem ;-) > > > >>I'm seeing the keypad lock-up on my N810 using this driver, > >>when I type quickly. > >> > >>I tried your patch, and it doesn't fix the issue. However, I've > >>read the datasheet for the lm8323 and it looks to me like the > >>interrupt should be level rather than edge triggered. > >> > >>The following additional patch makes things work for me. I > >>couldn't tell you if it's the correct thing to do but I can no > >>longer cause the keypad to lock-up by typing too fast. > > > >good good. Looks like IRQF_ONESHOT is what did the trick. > > > >Did you check if IRQF_ONESHOT alone was enough ? > > I tried that first, but it didn't fix it, although it makes it a > little bit harder to trigger. I've just tried again to be sure, > but I got a lock-up quite easily. Ok, cool thanks... Can you send your patch as a proper patch (with your Signed-off-by line and everything) saying that it fixes the lock up ? My patch converts to threaded IRQ and yours fixes the triggering ;-) -- balbi
Attachment:
signature.asc
Description: Digital signature
