On Thu, Jun 16, 2011 at 8:12 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote: > On Wed, Jun 15, 2011 at 11:33:40PM +0900, Magnus Damm wrote: >> From: Magnus Damm <damm@xxxxxxxxxxxxx> >> >> The MODE_6 support in sh_keysc.c is incorrect without >> this patch. According to the data sheet for G4, AP4 and >> AG5 KEYSC MODE_6 is 8x8 keys. Bump up MAXKEYS to 64 too. >> >> Signed-off-by: Magnus Damm <damm@xxxxxxxxxxxxx> > > Reviewed-by: Simon Horman <horms@xxxxxxxxxxxx> Thanks! > Do we also need to update the platform data for ag5evm > which is currently using SH_KEYSC_MODE_6 but with 49 > entries in its keysc_platdata.keycodes ? Yes, eventually we need to update the board support code as well. Chances are that existing out-of-tree board support code is broken. So we need updated platform data together with a pinmux configuration that matches the board schematics. Tested on real hardware using evtest. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
