On Mon, Jun 13, 2011 at 2:15 AM, Barry Song <21cnbao@xxxxxxxxx> wrote: > Hi Grant, > Thanks. > > 2011/6/13 Grant Likely <grant.likely@xxxxxxxxxxxx>: >> On Thu, Jun 9, 2011 at 8:28 PM, Barry Song <Baohua.Song@xxxxxxx> wrote: >>> The current ads7846 has no OF match table. The method used is by applying a heuristic (of_modalias_node) which tries to name the device in a way that will match an existing device driver. >>> This patch adds explicit OF match table for ads7846, then the normal device tree match behaviour will always work. >>> It has been tested on PRIMA2 EVB board of CSR with a SPI's child node like the below: >>> ts@0 { >>> compatible = "ti,ads7845"; >>> reg = <0x0>; >>> spi-max-frequency = <31250>; >>> interrupts = <90>; >>> }; >>> >>> Signed-off-by: Barry Song <21cnbao@xxxxxxxxx> >>> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx> >>> cc: Thomas Chou <thomas@xxxxxxxxxxxxx> >>> --- >>> drivers/input/touchscreen/ads7846.c | 14 ++++++++++++++ >> >> There should also be documentation for the new binding added to >> Documentation/devicetree/bindings for the new compatible strings. > > Which directory do you think is the best to place this document? or do > we build a new diretory named > Documentation/devicetree/bindings/input/touchscreen/ ? > The dir Documentation/devicetree/bindings seems to be for spi host, > not for spi clients. Documentation/devicetree/bindings/input sounds appropriate. g. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html