On Sat, Jun 04, 2011 at 01:26:28PM +0200, Marco Chiappero wrote: > Il 04/06/2011 10:43, Mattia Dongili ha scritto: > >when sony_call_snc_handle(handle, 0x200,&result) fails above you will > >be reporting -1 via the acpi bus. The old code restored the event and > >reported the raw number instead. > > You are right, does the following sony_nc_notify modification look > fine to you? > > /* hotkey event, a key has been pressed, retrieve it */ > value = sony_nc_hotkeys_decode(handle); > if (value > 0) /* known event */ > sony_laptop_report_input_event(value); > else /* restore the original event */ > value = event; it's a bit out of context but I guess it should work. It would be good to have sony_nc_hotkeys_decode also report the "not decoded" case consistently back to callers though. -- mattia :wq! -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html