Re: [PATCH 3.0-rc1 v2] Input: omap-keypad: add missing input_sync()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 04, 2011 at 05:00:41PM +0200, Janusz Krzysztofik wrote:
> Otherwise the updated evdev driver (commit cdda911c34006f1089f3c87b1a1f, 
> "Input: evdev - only signal polls on full packets") no longer works on 
> top of omap-keypad.
> 
> Tested on Amstrad Delta.
> 
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx>
> ---
> v1 -> v2 change, suggested by Henrik Rydberg (thanks!):
> - no need for a special variable tracing if input_sync is required - 
>   the input core already does the same thing.
> 
>  drivers/input/keyboard/omap-keypad.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- git/drivers/input/keyboard/omap-keypad.c.orig	2011-06-04 16:18:37.000000000 +0200
> +++ git/drivers/input/keyboard/omap-keypad.c	2011-06-04 16:46:23.000000000 +0200
> @@ -209,6 +209,7 @@ static void omap_kp_tasklet(unsigned lon
>  #endif
>  		}
>  	}
> +	input_sync(omap_kp_data->input);
>  	memcpy(keypad_state, new_state, sizeof(keypad_state));
>  
>  	if (key_down) {

    Reviewed-by: Henrik Rydberg <rydberg@xxxxxxxxxxx>

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux