On Thu, 26 May 2011, Dan Carpenter wrote: > Returning -1 is -EPERM which is inappropriate here. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c > index b2f9a3a..80b8e76 100644 > --- a/drivers/hid/usbhid/hiddev.c > +++ b/drivers/hid/usbhid/hiddev.c > @@ -890,8 +890,9 @@ int hiddev_connect(struct hid_device *hid, unsigned int force) > return -1; > } > > - if (!(hiddev = kzalloc(sizeof(struct hiddev), GFP_KERNEL))) > - return -1; > + hiddev = kzalloc(sizeof(struct hiddev), GFP_KERNEL); > + if (!hiddev) > + return -ENOMEM; > > init_waitqueue_head(&hiddev->wait); > INIT_LIST_HEAD(&hiddev->list); > @@ -905,7 +906,7 @@ int hiddev_connect(struct hid_device *hid, unsigned int force) > hid_err(hid, "Not able to get a minor for this device\n"); > hid->hiddev = NULL; > kfree(hiddev); > - return -1; > + return retval; > } > return 0; > } Why would that matter? hid_connect() (which is the only caller) only checks for the return value being (non-)zero. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
