Hi Jeffrey, On Thu, May 26, 2011 at 12:37:22AM -0700, Jeffrey Brown wrote: > Hi Dmitry, > I was just reviewing the final patch for the EV_SYN wake-up > optimization. I'm glad to see it made it in. It'll let me strip out > some unsightly hacks elsewhere. :) > > Anyways, my original patch contained this proposed change to > evdev_event, which seems to have been accidentally omitted: > > - wake_up_interruptible(&evdev->wait); > + if (full_sync) > + wake_up_interruptible(&evdev->wait); > } > > The idea was that we should only wake waiters on the event device when > we actually post an EV_SYN / SYN_REPORT to the queue. Otherwise we > end up making waiting threads runnable again only for them to go right > back to sleep because the device still isn't readable. > > So I think we want something like this in evdev_event: > > if (type == EV_SYN && code == SYN_REPORT) > wake_up_interruptible(&evdev->wait); > > What do you think? Yep, it looks like in all this code shuffling I did miss that piece. I'll fix that up, thanks for noticing. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
