Hi Rakesh, On Mon, May 02, 2011 at 05:23:08PM -0700, riyer@xxxxxxxxxx wrote: > From: Rakesh Iyer <riyer@xxxxxxxxxx> > > Modify wakeup logic so either all keypresses wake the system or none do. > > Signed-off-by: Rakesh Iyer <riyer@xxxxxxxxxx> > --- > v1: Modify wakeup logic so either all keypresses wake the system or none do. > > arch/arm/mach-tegra/include/mach/kbc.h | 4 +--- > drivers/input/keyboard/tegra-kbc.c | 28 ++++------------------------ > 2 files changed, 5 insertions(+), 27 deletions(-) > > diff --git a/arch/arm/mach-tegra/include/mach/kbc.h b/arch/arm/mach-tegra/include/mach/kbc.h > index bd99744..6b8e934 100644 > --- a/arch/arm/mach-tegra/include/mach/kbc.h > +++ b/arch/arm/mach-tegra/include/mach/kbc.h > @@ -50,14 +50,12 @@ struct tegra_kbc_platform_data { > unsigned int debounce_cnt; > unsigned int repeat_cnt; > > - unsigned int wake_cnt; /* 0:wake on any key >1:wake on wake_cfg */ > - const struct tegra_kbc_wake_key *wake_cfg; > - > struct tegra_kbc_pin_cfg pin_cfg[KBC_MAX_GPIO]; > const struct matrix_keymap_data *keymap_data; > > bool wakeup; > bool use_fn_map; > bool use_ghost_filter; > + bool wake_on_keypress; Why do we need new wake_on_keypress flag if we already have 'wakeup'? What besides a keypress can be used as a wakeup source with this device? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html