On Fri, 2011-02-25 at 11:04 +0100, Antonio Ospite wrote: > + [AC_LANG_PROGRAM([[ > + #include <sys/ioctl.h> > + #include <linux/hidraw.h> > + #if ! (defined(HIDIOCSFEATURE) && > defined(HIDIOCGFEATURE)) > + #error "HIDIOCSFEATURE and > HIDIOCGFEATURE are required (linux-libc-dev >= 2.6.3x)" > + #endif > + ]], The only part of the patch I have a problem with is this one. I'd rather the code had: #ifndef HIDIOCSFEATURE #define HIDIOCSFEATURE bleh #endif And gracefully handled the ioctl not being available on the running kernel (eg. "Not handling plugged in Sixaxis joypad because the kernel lacks HIDIOCSFEATURE support"). The rest looks fine, and I'll be testing whether my Fedora 15 kernel has the feature merged in yet (which would make testing your code much easier). Cheers -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
