On 04/29/2011 04:52 PM, Michael Hennerich wrote: > On 04/29/2011 11:55 AM, Jonathan Cameron wrote: >> Cc'd input, and analog devices driver list... >> >> On 04/28/11 19:17, Jean-Francois Dagenais wrote: >> >> >>> I also had to change the request_threaded_irq flags to specify >>> IRQF_ONESHOT so the kernel keeps the interrupt masked while we are >>> running ad714x_interrupt_thread(). Otherwise we were getting storms >>> of interrupts each time only one was requested. I am wondering if >>> this should be pulled back to the mainline kernel? >>> >>> Thanks for pointers and clues! >>> >>> > I assume this is due to the fact that the interrupt on the host is > level sensitive. > In this case you need to use the IRQF_ONESHOT flag. > The unmodified driver requests the IRQ as IRQF_TRIGGER_FALLING, so > this is not necessary. > > To my knowledge we regularly test the driver with the sliders, wheels > and buttons found on the > official evaluation board, and so far we haven't found oddities. > For an example platform file see: arch/blackfin/mach-bf537/boards/stamp.c > From top of my head I don't know whether we're testing with the SPI or > I2C interface. > > http://wiki.analog.com/software/driver/linux/ad714x > -- Greetings, Michael -- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
