On Tue, Apr 12, 2011 at 01:20:11AM +0200, Christoph Fritz wrote: > On Tue, Apr 12, 2011 at 01:02:17AM +0800, Jiejing Zhang wrote: > > + > > +static SIMPLE_DEV_PM_OPS(mpr121_touchkey_pm_ops, mpr_suspend, mpr_resume); > > + > > +static struct i2c_driver mpr_touchkey_driver = { > > + .driver = { > > + .name = "mpr121", > > + .owner = THIS_MODULE, > > + .pm = &mpr121_touchkey_pm_ops, > > I would add a ifdef CONFIG_PM_SLEEP > No, since we could try supporting CONFIG_PM_RUNTIME for example (not necessarily in this driver, but in general case). dev_pm_ops structire is defined always but it contents change de3pending on CONFIG_PM_SLEEP. CONFIG_PM_RUNTILE and so forth. At a minium it is an empty structure, but it woudl still be defined. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html