On 04/07/11 17:18, Anisse Astier wrote:
>
> Pegatron Lucid tablet sends an ACPI hotkey event(0xEA) when the
> accelerometer detects coarse orientation change. My initial thought was
> to just translate this event into KEY_DIRECTION, which seems to be the
> norm from what we can see in hp-wmi driver. (See patch below for an
> implementation.)
>
> But this isn't just a key per se like on the HP touchsmart tablet, this
> is an event that is triggered when the device is rotated.
>
> This could be defined as a new Misc (EV_MSC) event:
> MSC_ORIENTATION_CHANGED ?
>
> Or we could use the upcoming IIO subsystem which is supposed to be for
> sensors, but then we'd have a mismatch between the device based on ACPI
> with firmware in the middle (driver submitted by Andy Ross) and the
> purpose of IIO ("SPI or I2C device").
Don't take that too literally. It's examples of types of bus IIO sensors use.
Having said this, if your main use is user input then it should probably be
handled through input rather than IIO anyway.
>
> Maybe I'm over-thinking this and this might be just right:
>
> From: Anisse Astier <anisse@xxxxxxxxx>
> Subject: [PATCH RFC] asus-laptop: Send input key for tablet rotation on Pegatron Lucid Tablet
>
> Pegatron Lucid tablet sends ACPI event on coarse orientation changes.
> Translate this into KEY_DIRECTION input event.
>
> Cc: Dmitry Torokhov <dtor@xxxxxxx>
> Cc: Matthew Garrett <mjg@xxxxxxxxxx>
> Cc: Andy Ross <andy.ross@xxxxxxxxxxxxx>
> Cc: Corentin Chary <corentin.chary@xxxxxxxxx>
> Signed-off-by: Anisse Astier <anisse@xxxxxxxxx>
> ---
> Please note that this patch depends on Andy Ross's first patch in order for
> asus-laptop to bind with the tablet.
>
> Regards,
>
> Anisse
> ---
> drivers/platform/x86/asus-laptop.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index 5c23b20..decb958 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -312,6 +312,8 @@ static const struct key_entry asus_keymap[] = {
> {KE_KEY, 0xc4, { KEY_KBDILLUMUP } },
> {KE_KEY, 0xc5, { KEY_KBDILLUMDOWN } },
> {KE_KEY, 0xb5, { KEY_CALC } },
> + /* Pegatron Lucid tablet specific */
> + {KE_KEY, 0xEA, { KEY_DIRECTION } }, /* Orientation changed */
> {KE_END, 0},
> };
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
