Re: [PATCH v2] Wacom Intuos4 LED and OLED support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

2011/4/5 Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>:
> On Tue, Apr 05, 2011 at 08:12:07PM +0200, Eduard Hasenleithner wrote:
>> I have been encouraged by Ping Cheng to submit the OLED matrix display
>> patch for the Intuos4 to the linux-input mailing list. In absence of
>> any comment by you on this issue, I'm a bit lost. Could you give
>> something like a quick ACK (e.g. you will have a look into it later,
>> when you have time) or NACK (e.g. no way for inclusion, needs major
>> change, ...).
>
> Sorry, just a bit swamped at the moment (unfortunately happens to be
> quite often ;( ), that is why not responding...

If you like, I can come back in a month or so for discussion. Or you
write me an email when you are less stressed (you being a maintainer,
this is probably just wishful thinking).

> The main issue for me is adding a new device-specific interface. Are
> there any other suitable ways to provide access to the functionality?
> Something like auxdisplay?

I had the impression that using the existing RAW USB-device IOCTL
mechanism would not be considered an additional interface. There is no
change in the event- or any other subsystem, just in the wacom driver.
And, as a bonus, using sysfs the RAW USB Device belonging to the event
device can be located in a straight forward way. Since the wacom
driver "grabs" the USB device and the OLED part of the Intuos4 is not
a separate USB device, the display control has to be performed in any
case in the wacom (input) driver. A "auxdisplay" implementation would
then have to be done also there.

Wrt auxdisplay: a quick look at the driver reveals that it exposes a
(generic?) framebuffer device. If you say: "This is the way to go",
I'll try it. It is just that I fear that some X-Server might
automatically use it as display, which is not exactly my intention ;)
Furthermore, there are four LEDs (only one can be lit at a time) on
the device, and three different luminace settings, which would
probably need some IOCTL anyway. And due to the higher complexity,
implementing a (simulated) framebuffer device provides more
possibilities for bugs.

Thanks,
Eduard
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux