On 03/30/2011 01:02 PM, Dmitry Torokhov wrote:
Hi Chris, On Wed, Mar 30, 2011 at 07:05:24AM -0700, Christopher Heiny wrote:This patch implements a driver supporting Synaptics ClearPad and other touchscreens that use the RMI4 protocol, as defined here: http://www.synaptics.com/sites/default/files/511-000136-01_revD.pdf This patch is against the v2.6.38 tag of Linus' kernel tree, commit 521cb40b0c44418a4fd36dc633f575813d59a43d. Note that previous patches were against the synaptics-rmi4 branch of Dmitry Torokhov's input tree. At Dmitry's request, we have switched the base for our work to v2.6.38 - this should make it easier for people to pick up and test this and future patches.The source as sumitted is quite "dirty" i.e. littered with multiple #if 0...#endif etc. Cooudl you please clean it up and resubmit so that unneeded details/code would not get into the way of reviiewing the driver?
I've done some tidy up. Two #if 0's still exist, surrounding code that causes problems on some dev systems. The remaining #if 0's have been removed or converted to a more conventional and compact approach that shouldn't interfere with understanding the code.
I've also removed a bunch of extraneous printks. Patch to follow in a few minutes. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
