On Wed, 30 Mar 2011, root wrote:
> From: Marek Becka <yuen@xxxxxxxxx>
Some explanation (changelog) would be good to have.
Also, your message has been sent with 'From: root <root@xxxxxxxxxxxxxx>',
which looks rather strange.
> diff --git a/drivers/hid/hid-axff.c b/drivers/hid/hid-axff.c
> index b455428..c0a4bf6 100644
> --- a/drivers/hid/hid-axff.c
> +++ b/drivers/hid/hid-axff.c
> @@ -50,7 +50,7 @@ static int axff_play(struct input_dev *dev, void *data, struct ff_effect *effect
> left = effect->u.rumble.strong_magnitude;
> right = effect->u.rumble.weak_magnitude;
>
> - dbg_hid("called with 0x%04x 0x%04x", left, right);
> + HID_DBG("called with 0x%04x 0x%04x", left, right);
[ ... snip ... ]
> diff --git a/include/linux/hid.h b/include/linux/hid.h
> index bb29bb1..eaad657 100644
> --- a/include/linux/hid.h
> +++ b/include/linux/hid.h
> @@ -686,8 +686,6 @@ struct hid_ll_driver {
>
> /* HID core API */
>
> -extern int hid_debug;
> -
> extern int hid_add_device(struct hid_device *);
> extern void hid_destroy_device(struct hid_device *);
>
> @@ -888,11 +886,8 @@ int hid_pidff_init(struct hid_device *hid);
> #define hid_pidff_init NULL
> #endif
>
> -#define dbg_hid(format, arg...) \
> -do { \
> - if (hid_debug) \
> - printk(KERN_DEBUG "%s: " format, __FILE__, ##arg); \
> -} while (0)
> +#define HID_DBG(fmt, arg...) \
> + pr_debug("%s: " fmt "\n" , __func__ , ##arg)
>
1) why changing the name from dbg_hid to HID_DBG all over the place?
2) why removing the 'if (hid_debug)' condition?
--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
