Re: [PATCH 2/2] input : wacom - report resolution for pen devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 27, 2011 at 11:59:29AM -0700, Ping Cheng wrote:
> On Sun, Mar 27, 2011 at 7:32 AM, Chris Bagwell <chris@xxxxxxxxxxxxxx> wrote:
> 
> > On Fri, Mar 25, 2011 at 7:29 PM, Ping Cheng <pinglinux@xxxxxxxxx> wrote:
> > > Touch resolution is reported to the userland by retrieving
> > > the value from the HID descriptor. But pen resolution is not
> > > since it can not be retrieved. The current Wacom X driver
> > > has a resolution table. To centralize the source of these
> > > values, the resolution entries are added in the wacom_features
> > > struct for x and y coordinates respectively. The values are
> > > then reported to the userland.
> > >
> > > Signed-off-by: Ping Cheng <pingc@xxxxxxxxx>
> >
> > I'm glad you gave up on me saying I'd eventually make this change. :-)
> >
> > My hold up was I was debating to myself if it should have separate X/Y
> > resolutions or just a single field.  Its unlikely Wacom will ship
> > unmatched X/Y's.  For what its worth, a  version of this change in my
> > local tree also kept separate X/Y's.
> >
> 
> I thought about that when I worked on the patch too. I decided to have
> separate entries for x and y since it adds flexibility for future devices.
> 

Applied both, altough without Chris's reviwed-by tags as I already pushed
by public branch out...

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux