On Mon, Mar 21, 2011 at 02:32:16PM +0100, Benjamin Tissoires wrote: > Hi Henrik, > > On Mon, Mar 21, 2011 at 10:02, Henrik Rydberg <rydberg@xxxxxxxxxxx> wrote: > > On Fri, Mar 18, 2011 at 02:27:55PM +0100, Benjamin Tissoires wrote: > >> No semantic changes, it's just easier to read the code. > > > > Please augment this commit message. > > How about: > > "The way the input_set_abs_params was called for the new composite > field ABS_MT_ORIENTATION was not very clear at second reading. > We can remove the non-necessary call to set_abs and use the simple > call to input_set_abs_params." Sure thing. In addition, the old code was setting the hid parameters for the wrong field, which was odd. Thanks, Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
