Hi, Iiro. 2011/3/17 Iiro Valkonen <iiro.valkonen@xxxxxxxxx>: > Make the CHG line (interrupt line) go high after the interrupts have been enabled to make sure we don't miss the falling edge. > > Signed-off-by: Iiro Valkonen <iiro.valkonen@xxxxxxxxx> > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c > index f8cd478..ca2062a 100644 > --- a/drivers/input/touchscreen/atmel_mxt_ts.c > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c > @@ -804,10 +804,6 @@ static int mxt_initialize(struct mxt_data *data) > if (error) > return error; > > - error = mxt_make_highchg(data); > - if (error) > - return error; > - > mxt_handle_pdata(data); > > /* Backup to memory */ > @@ -1098,6 +1094,10 @@ static int __devinit mxt_probe(struct i2c_client *client, > if (error) > goto err_unregister_device; > > + error = mxt_make_highchg(data); > + if (error) > + goto err_unregister_device; > + You are missing one error handling about sysfs_create_group() and please consider firmware update flow also. Thanks. > return 0; > > err_unregister_device: > -- > 1.7.0.4 > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- - Joonyoung Shim -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
