On Wed, Mar 16, 2011 at 2:32 PM, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > On Wed, Mar 16, 2011 at 02:10:30PM +0900, Magnus Damm wrote: >> From: Magnus Damm <damm@xxxxxxxxxxxxx> >> >> Extend the tca6416 driver to use enable_irq_wake() >> and disable_irq_wake() in the suspend/resume hooks. >> >> This makes it possible to wake up from suspend-to-ram >> using a tca6416 key on the sh7372 mackerel board. >> > > Hi Magnus, > > Looks good, but why don't we guard PM code with CONFIG_PM_SLEEP, like > below? I also believe we should use bus-specific helpers to access > private driver data since it does not have to stay alias for the > core data pointer. Hi Dmitry, Thank you for the updated patch, your version looks much better than mine. I tested your version on my Mackerel board a few minutes ago and it is still working as expected. Unless there are any objections, please merge your version of the patch. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
