On 11 March 2011 08:31, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > I must say I am very wary about this patch. I know that there are a few > boxes that will get very confused if we do not reset their > mice/touchpads to the bare PS/2 protocol and I also do not believe that > we can rely on devices keeping their protocol settings after s2r and > especially s2d even if they are marked as wakeup sources. > > I understand that that may be the case with OLPC but not with other > boxes... I agree. Thats why the whole thing is hidden behind i8042_enable_wakeup - so that it only happens on OLPC and not other platforms. I don't see i8042-based wakeup being possible in any other scenario. If you prefer I could drop the module_param access to that variable so that it can't even be enabled except when appropriate platforms are detected. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
