Hi Richard, Thank you very much for this work. This reminds me that we have to switch the other drivers to hid-multitouch too. Actually, I was not in favor of porting this driver into hid-multitouch. eGalax has two differents protocols: one for resistive technology (which is compatible with hid-multitouch in its current form), and one for capacitive technology (which requires the "corrupt packet length" quirk). Apparently, according to the kernel logs the Samsung MB30 is a resistive technology (correct me if I'm wrong). This means that we also need testings for the capacitive one. I'll let the community decide whether we should include this in hid-multitouch. Henrik, Jiri, any idea? Now let's go for the review! Cheers, Benjamin On Sun, Mar 6, 2011 at 14:24, Richard Nauber <richard.nauber@xxxxxxxxxxxxxx> wrote: > Hi everyone, > I wrote this little patch that merges hid-egalax into hid-multitouch. > (It applies to 2.6.38-rc7, but I can rebase it as you please...) The > latter driver has to gain a new quirk type (MT_QUIRK_EGALAX) for fixing > the reported ranges (X,Y and Z) and work around the corrupt packet > length (td->last_field_index). > With these changes it works like a charm for my Samsung MB30 > touchscreen and by the way fixes the broken suspend/resume behavior. > > So I'd like you to test it for other egalax devices and give me your > feedback on this patch. > > Thanks and Greetings, > Richard > > [input-hid] Add hid-egalax driver to the unified hid-multitouch > framework. > > drivers/hid/Kconfig | 9 +- > drivers/hid/Makefile | 1 - > drivers/hid/hid-egalax.c | 279 > ------------------------------------------ > drivers/hid/hid-multitouch.c | 48 +++++++- > 4 files changed, 47 insertions(+), 290 deletions(-) > delete mode 100644 drivers/hid/hid-egalax.c > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
