Hi Benjamin, > after some quick tests, I can deal with our two options (changing > feature_mapping signature or not, and so calling feature_mapping > before or after input_mapping). Good, good. > So, my questions are: > - do we really need to change feature_mapping signature? > - is feature_mapping tied to an input or to a device? The input, output and feature reports are all found on the same level in the HID protocol, so it makes sense to associate all reports with the device itself, without any assumed association between different reports. From a practical point of view, we may assign different input nodes (input devices) to different input reports, so it is clear that the mapping between hid device and input device is not 1-to-1. For output devices, the only supported case is EV_LED, which passes events to the input device. It is probably assumed that HID_QUIRK_MULTI_INPUT is false for those devices. Jiri? For feature reports, the lack of 1-1 correspondence suggests the input device is ill-defined, and should therefore be left out of the argument list of the callback. However, I will leave that to Jiri or anyone more experienced with the HID layer. Thanks, Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
