On Fri, Feb 18, 2011 at 12:17:57PM +0300, Dan Carpenter wrote: > The test here is reversed. It should be if (IS_ERR()) instead of > if (!IS_ERR()). > Awww, crap... Applied, thanks Dan. > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c > index 7f8331f..364bdf4 100644 > --- a/drivers/input/misc/uinput.c > +++ b/drivers/input/misc/uinput.c > @@ -362,7 +362,7 @@ static int uinput_setup_device(struct uinput_device *udev, const char __user *bu > dev = udev->dev; > > user_dev = memdup_user(buffer, sizeof(struct uinput_user_dev)); > - if (!IS_ERR(user_dev)) > + if (IS_ERR(user_dev)) > return PTR_ERR(user_dev); > > udev->ff_effects_max = user_dev->ff_effects_max; -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
