Alright I will redo my patch with Function keys defined in their separate rows. Regards Rakesh > -----Original Message----- > From: Dmitry Torokhov [mailto:dmitry.torokhov@xxxxxxxxx] > Sent: Wednesday, February 16, 2011 1:20 PM > To: Rakesh Iyer > Cc: linux-input@xxxxxxxxxxxxxxx; olofj@xxxxxxxxxxxx; Andrew Chew > Subject: Re: [PATCH v3] input: tegra-kbc: Add Function keymap. > > On Wed, Feb 16, 2011 at 12:12:54PM -0800, Rakesh Iyer wrote: > > I agree with that, and that was my original plan. > > > > But I saw matrix_keypad.h has the MATRIX_MAX_ROWS defined at 16, and decided to > > accommodate for it. > > > > Conveniently we just increased MATRIX_MAX_ROWS/COLS to 32 (see > commit cfaea56741360311d0dabcb6603fa78c2e3de155 in mainline). > > Thanks. > > -- > Dmitry ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html