Hi, On Wed, 15 Dec 2010, Dmitry Torokhov wrote:
On Wed, Dec 15, 2010 at 11:39:12AM +0200, Srikar wrote:Hi ToroKhov, TSC2005 is using SPI interface/driver and TSC2007 driver is using i2C Interface/driver are main differences.I see. In this case I believe that, instead of creating completely separate driver, we need to abstract bus access from tsc2007 and convert the driver into tsc200x-core.c core piece and tcs2005.c/tsc2007.c implementing just bus access methods. Pretty much what was done for ad714x, adxl34x, ad7879 and other drivers.
I think there are more differences than just the bus access. The command interface is different, including register definitions. TSC2007 data sheet mentions it's compatible with TSC2003 but does not mention TSC2005. I would keep them separate, and I think this patch should be applied for .39 (the subject is wrong - it's just a single patch: https://patchwork.kernel.org/patch/357012/). A. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
