On Mon, 7 Feb 2011, Chris Schlund wrote:
> Hi Jiri,
>
> I already got some feedback for this module, telling me red and blue keys are exchanged.
> I checked it, and they are right. Due to my incorrect userspace settings I missed this during my testing.
> So here is the fixed mapping.
> I am sorry for the inconvenience.
>
> Thanks, Chris
>
>
> Signed-off-by: Chris Schlund <chrisschlund@xxxxxx>
> ---
>
> diff -urN linux-2.6.37/drivers/hid/hid-lcpower.c linux/drivers/hid/hid-lcpower.c
> --- linux-2.6.37/drivers/hid/hid-lcpower.c 2011-02-07 17:31:49.000000000 +0100
> +++ linux/drivers/hid/hid-lcpower.c 2011-02-07 17:32:50.000000000 +0100
> @@ -30,8 +30,8 @@
> switch (usage->hid & HID_USAGE) {
> case 0x046: ts_map_key_clear(KEY_YELLOW); break;
> case 0x047: ts_map_key_clear(KEY_GREEN); break;
> - case 0x049: ts_map_key_clear(KEY_RED); break;
> - case 0x04a: ts_map_key_clear(KEY_BLUE); break;
> + case 0x04a: ts_map_key_clear(KEY_RED); break;
> + case 0x049: ts_map_key_clear(KEY_BLUE); break;
We'd rather keep the numbers sorted. Plus your patch has been
whitespace-damaged by your mail-client.
I have fixed both things and applied. Please fix your mail client for
further patch submissions.
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
