On Wed, 26 Jan 2011, Alan Ott wrote: > Setting of the return value of hidraw_read() uses the += operator when > = is more appropriate. There is no case where ret can be anything > other than zero when the assignment is made, making = equivalent to > += and much more clear. > > Signed-off-by: Alan Ott <alan@xxxxxxxxxxx> > --- > drivers/hid/hidraw.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c > index 468e87b..66fbcba 100644 > --- a/drivers/hid/hidraw.c > +++ b/drivers/hid/hidraw.c > @@ -91,7 +91,7 @@ static ssize_t hidraw_read(struct file *file, char __user *buffer, size_t count, > ret = -EFAULT; > goto out; > } > - ret += len; > + ret = len; > Applied, thanks. -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
