Re: [PATCH] input : wacom - report resolution for ABS_MT events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 28, 2011 at 4:05 PM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> On Fri, Jan 28, 2011 at 01:57:17PM -0800, Ping Cheng wrote:
>> On Fri, Jan 28, 2011 at 12:54 PM, Dmitry Torokhov
>> <dmitry.torokhov@xxxxxxxxx> wrote:
>> >> >> > so I believe
>> >> >> > min, max and resultion should be reported on ABS_X, Y, X, etc, or, if
>> >> >> > you want to have this data in ABS_MT_POSITION, it should be trhe same.
>> >> >>
>> >> >> max/min is different from resolution. We can scale max/min since they
>> >> >> are logical data. But we can not change the device's physical size.
>> >> >> That's the root cause of the "stubborn" nature of resolution.
>> >> >
>> >> > This is the same device so it should have the same physical dimensions,
>> >> > right?
>> >>
>> >> No, pen and touch use different chips. They can have different sizes.
>> >
>> > It does not matter how many chips you have inside. What matters whether
>> > they share a working surface or not. If working surface is the same (and
>> > consequentially you have single input_dev structure) then dimensions are
>> > the same.
>>
>> They do not always share the exact same surface. Most of the devices
>> do have the same working surface. But not all of them although the
>> differences are normally small. To represent a finger touch, it may
>> not be too big a deal. But, making the assumption that they are the
>> same size doesn't sound right.
>>
>> Do we ignore that small imprecision?
>
> I think we should consider these cases as having roughly the same
> dimensions of working surfaces. Because if we do what you are proposing
> the next thing we'll see an MT device that can report several tools
> simultaneously and your scheme breaks apart.
>
> Devices with surface characteristics so different that they can't be
> handled well by scaling to common denominator should probably be
> presented as 2 independent logical devices.

Dmitry,

Version 2 will be sent incorporating the above comments in a moment.

Henrik,

The Bamboo resolution has already been scaled since we calculated it
through the scaled logical maximum. So, no changes needed there.

Ping
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux