On Fri, Jan 28, 2011 at 18:33, Henrik Rydberg <rydberg@xxxxxxxxxxx> wrote: > On Thu, Jan 27, 2011 at 01:49:18PM +0100, Benjamin Tissoires wrote: >> Hi Henrik, >> >> On Thu, Jan 27, 2011 at 13:06, Henrik Rydberg <rydberg@xxxxxxxxxxx> wrote: >> > Hi Benjamin, >> > >> > On Thu, Jan 27, 2011 at 11:35:46AM +0100, Benjamin Tissoires wrote: >> >> This patch adds the function input_mt_get_abs_value(), which may be >> > >> > Ehm, input_mt_get_absinfo? >> >> In fact, the idea was to put this on the table again ;). I have no >> idea of what is the right think to do in such case. >> So I'll take all comments. >> >> > >> >> used to extract the current state of the MT slots. >> >> >> >> Signed-off-by: Henrik Rydberg <rydberg@xxxxxxxxxxx> >> > >> > I had rather re-add this myself, thanks. >> >> That was my question. Plus I had a subliminal message in which I >> intend you to take the drive on this work. ;) > > Thanks for the patches, Benjamin, perhaps they do need a bit of > rewrite or a new ioctl. We will see what happens. > Today I found a bug in these 2 patches: they send garbage with devices that use protocol A. This is definitely a bad idea to send the input_absinfo. In addition to that, using the original behavior (which seems better) does not seems to add sth in regard to input_mt_get_value. It would just add some guards that can be resumed in just a test: (code >= ABS_MT_FIRST && code <= ABS_MT_LAST && dev->mt && slot >= 0 && slot < dev->mtsize) Henrik, if you want to introduce the new IOCTL, feel free, I don't need it right now. Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
