Re: [PATCH] evdev: fix evdev_write return value on partial writes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> "Baruch" == Baruch Siach <baruch@xxxxxxxxxx> writes:

 >> Fix it by only handling each full input_event structure, similar to
 >> how it is done in evdev_read.

 Baruch> A Reporte-by here would be nice.

Sorry, forgot. Dmitry, could you add it when you commit the patch.

 >> Signed-off-by: Peter Korsgaard <jacmet@xxxxxxxxxx>

 Baruch> As I said on the Busybox list, applying this results in an endless

 Baruch> write(1, "test\n", 5)                   = 0
 Baruch> write(1, "test\n", 5)                   = 0
 Baruch> write(1, "test\n", 5)                   = 0
 Baruch> write(1, "test\n", 5)                   = 0
 Baruch> write(1, "test\n", 5)                   = 0
 Baruch> write(1, "test\n", 5)                   = 0
 Baruch> write(1, "test\n", 5)                   = 0

 Baruch> from the command

 Baruch> echo test > /dev/input/event0

 Baruch> write() should probably return -EINVAL here.

Indeed, like we do in evdev_read. Updated patch sent.

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux