> Hmm, if it is platform driver then you need to also post it to the > platform driver list/Matthew. If you want it to be an input driver > please move to drivers/input/misc/. Will do - wanted to check it was ok on the input side first. > > +config INTEL_MID_POWER_BUTTON > > + tristate "power button driver for Intel MID platforms" > > + depends on INTEL_SCU_IPC > > + default y > > 'y' is for essential features I believe. Good point - fixed > > > + help > > + This driver handles the power button on the Intel MID platforms. > > + > > + If unsure, say N. > > + > > To compile this driver as a module... Thats a form the platform/x86 driver Kconfig never uses - not sure of the history of that choice > > + ret = intel_scu_ipc_ioread8(MSIC_PB_STATUS, &pbstat); > > Is this sleeping? Yes - hence the threade IRQ. The SCU is basically another device we send messages to and which sends us replies back. > Space after comma please. Fixed > You are forgetting to free IRQ. Fixed Will now send it to mjg -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
