On Tue, Jan 25, 2011 at 05:05:05PM +0000, Corentin Chary wrote: > On Tue, Jan 25, 2011 at 4:43 PM, Andy Ross <andy.ross@xxxxxxxxxxxxx> wrote: > > On 01/24/2011 11:30 PM, Corentin Chary wrote: > >> Dmitry Torokhov wrote: > >> > I am happy with the input part but I wonder if it really needs to be > >> > separate? If you roll it up into asus-laptop you would not need a new > >> > platform device and then it would be what - 20 lines of code? > >> > > >> > Corentin, what do you think? > >> > >> I think that it should be consistent, if there is already some code > >> for pegatron tablet in asus-laptop, then why a new platform device > >> only for the accelerometer ? > > > > No strong feelings here. I made it a separate file because > > asus-laptop.c is already very large and this was something that could > > be fairly easily split out, but obviously it's a really trivial > > device. > > > >> Andy, what is shared with asus-laptop exactly ? What sysfs files are > >> working and enabled ? Are backlight and led classes working ? > > > > Just the key device, which exports the single touch area in the corner > > of the tablet as KEY_MEDIA. Some of the other sysfs devices > > (bluetooth, display, leds) appear because the methods exist, but > > they're stubbed out in the ASL and thus noops. > > > > Andy > > If everybody is ok with that, I think you should move the code back > into asus-laptop.c. But if you do so, don't forget to modify the help > text of ASUS_LAPTOP section in KConfig. > > Should we also change the description to > "Asus/Medion/JVC/Lenovo/Pegatron Extra" ? That seems really ugly > but.... "Kitchen sink" so we do not need to adjust the description going forward? ;P -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
