Hi Ping,
> @@ -1228,8 +1228,13 @@ void wacom_setup_input_capabilities(struct input_dev *input_dev,
> case TABLETPC:
> if (features->device_type == BTN_TOOL_DOUBLETAP ||
> features->device_type == BTN_TOOL_TRIPLETAP) {
> - input_set_abs_params(input_dev, ABS_RX, 0, features->x_phy, 0, 0);
> - input_set_abs_params(input_dev, ABS_RY, 0, features->y_phy, 0, 0);
> + /* set touch resolution in points/mm */
> + res = features->x_phy/100;
> + input_abs_set_res(input_dev, ABS_X,
> + features->x_max/res);
It seems to me the construction above looses precision twice for no
apparent reason. How about instead use "100 * features->x_max /
features->x_phy"? Besides, it is a bit unfortunate that "res" is short
for both result and resolution. Finally, are the physical dimensions
actually presented in 100ths of millimeters?
Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
