On Thu, 13 Jan 2011, Stephan Raue wrote: > Remote Controls shipped with some new Jetway ION system has two event > interfaces : Keyboard and Mouse. Mouse buttons work but keyboard buttons > doesn't. > > The remote identifies itself as : > > Vendor:Device 0x0755:0x2626 > Cy se W-01RN USB_V3.1 > > the Remote Control has a bogus HID Report Descriptor. According to that report > descriptor, the maximum logical value for key events is 1 and not 101 (101 > keys). > > This quirk fixes this wrong Report Descriptor and is basically the same found > in hid-elecom.c. > > This patch is originally from > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/607062 with changes to > not oops on linux-2.6.37. > > > Signed-off-by: Stephan Raue <stephan@xxxxxxxxxxx> Hi Stepahn, thanks for the driver! A few comments though, before I can apply the driver - please always CC me on patches against drivers/hid/ - you are adding driver with Copyright of Franco Catrin <fcatrin@xxxxxxxxx>, but you are providing your own Signed-off-by only. What is the origin of the code, please? - additions to hid-ids.h don't really qualify for copyright - please don't add any new HID drivers with the 'EMBEDDED' stuff in Kconfig. You can read some explanation in the changelog text of commit 73d5e8f77e88a4d3a154dfdbb4ed2cf461b7bf21 ("HID: fix up 'EMBEDDED' mess in Kconfig"). - please send the patch inline in the message text, not attached Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
